Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rollback operations supported by datasetprotection policy #501

Merged
merged 3 commits into from
Jan 31, 2024
Merged

Rollback operations supported by datasetprotection policy #501

merged 3 commits into from
Jan 31, 2024

Conversation

gabfelp
Copy link
Contributor

@gabfelp gabfelp commented Jan 26, 2024

Description of the change

We are doing some improvements for correctly supporting these operations in dataset-protection policy

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • Jira issue referenced in commit message and/or PR title

Testing

@gabfelp gabfelp requested a review from wcmjunior January 26, 2024 20:27
@gabfelp gabfelp marked this pull request as draft January 31, 2024 00:08
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@gabfelp gabfelp marked this pull request as ready for review January 31, 2024 21:32
@wcmjunior wcmjunior merged commit 7f2ccec into main Jan 31, 2024
2 checks passed
@wcmjunior wcmjunior deleted the rollback-monitoring-ops branch January 31, 2024 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wcmjunior wcmjunior wcmjunior approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gabfelp @wcmjunior